[JDEV] About IRC Transport

Malli, Siva_Kumar Siva-Kumar-Malli at deshaw.com
Thu Oct 18 05:32:35 CDT 2001


	I didn't look into the code, but i am trying to help. When you issue
a /join command from the client and its succesful or when you issue a /names
command you will get a reply from the server with numeric code 353 which has
the channel name and all the names in that channel. The channel name can be
prefixed by "="/"*"/"@". '=' is to represent that the channel is a public
channel, @ for secret channels and * for private channels. So you must also
look for '*' from your code apart from'=' and '@'.
Thanks,
Siva.

----- Original Message ----- 
From: "David Sutton" <dsutton at legend.co.uk <mailto:dsutton at legend.co.uk>> 
To: <jdev at jabber.org <mailto:jdev at jabber.org>> 
Sent: Thursday, October 18, 2001 5:08 PM 
Subject: [JDEV] About IRC Transport 

> Hello,
> 
> I've also been looking at the transport, and found a different bug or
> two, although its mainly a problem with the implementation. On line 744,
> where we are trying to get a hash of users for a channel, the character
> '=' is used to find the part of the line which has the channel name in
> it. The problem is that i've seen that it can also be a '@' <mailto:'@'>,
which will
> cause it to fail. The fix I implemented works as follows:
> 
> /* :me 353 mynick = #channel :@me +you them */
> char *ptr;
> +char *delimit = "@ ";
> chans channel;
> 
> ptr = strchr(icpr->next, '=');
> if(ptr == NULL)
> +{
> + ptr = strstr(icpr->next, delimit);
> + if(ptr == NULL)
> + {
> + continue;
> + }
> +}
> 
> I had to use "@ " as using the @ by itself would mean it could match
> op'ed users.
> 
> I know that Benoit has done some excellent work on the transport so far
> and I would like to offer my help and services.
> 
> Regards,
> 
> David
> 
> 
> 
> _______________________________________________
> jdev mailing list
> jdev at jabber.org <mailto:jdev at jabber.org>
> <http://mailman.jabber.org/listinfo/jdev>




More information about the JDev mailing list