[jdev] jabberd 2.0 vcard-temp patch

[Robert B Quattlebaum, Jr.]

On Sep 15, 2005, at 11:26 AM, Norman Rasmussen wrote:


> See http://j2.openaether.org/bugzilla/show_bug.cgi?id=29 the patch has
> been around for about 6 months.
>

:: Looks at patch ::

That looks like a pretty minimal patch that just adds support for  
iChat style avatars and nothing else. My patch adds support for  
considerably more fields, all of which are supported by vcard-temp. I  
recommend we either use my patch instead, or add these fields in some  
other way.


> re: max_vcard_field_length/VCARD_MAX_FIELD_SIZE is there now a good
> way to make this limit go away....
> As Alex points out this should be a client side restriction only, so
> the server should handle _any_ size field.  This basically means that
> a malloc has to be done right? (instead of using a static char array).
>

Sounds reasonable to me in theory. For most every field, I added size  
limits to the database itself to specifically avoid having oversized  
vcards. They are all reasonable generous sizes... I'm already  
violating the vcard avatars JEP by allowing the avatar to be larger  
than 8k. (The limit imposed by my patch is 16k)

Granted, having something completely dynamically allocated would  
probably be ideal/most-flexible/most-secure, but I don't think we  
should do so for the sole reason of allowing more data to be stuffed  
into these stanzas.

__________________
Robert Quattlebaum
Mobile: +1(425)443-6785
eMail:  darco at deepdarc.com
Jabber: darco at deepdarc.com
MSN:    darco at deepdarc.com
AIM:    rquat2
yahoo:  robert_quattlebaum
ICQ:    1454810