[JDEV] [Fwd: [INFO] bug or perhaps undesirable legacy code in jabberd 1.42]

[Robert Norris]

> > line 124 of jsm/modules/mod_auth_0k.c

> >         if(mod_auth_0k_reset(m,m->user->id,m->user->pass));
> >             return M_PASS;

> > Since the line "if(mod_auth_0k_reset(m,m->user->id,m->user->pass));"
> > ends in a semi-colon, its evaluation is not used to determine whether or
> > not "return M_PASS;" is called.
> > 
> > In other words, the 2nd call to xdb_get is never called.

Good catch. Fixed in jabberd14 CVS.

Rob.

-- 
Robert Norris                                       GPG: 1024D/FC18E6C2
Email+Jabber: rob at cataclysm.cx                Web: http://cataclysm.cx/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <https://www.jabber.org/jdev/attachments/20030716/258ba5d3/attachment-0002.pgp>