[JDEV] Is this bug fixed after 1.2 ?

[Keith Minkler]

perhaps I can offer some assistance...

In versions of the jabber server, pre 1.4pre1, the <ns/> tag has been broken... the deliver logic fell short when it came to flags like this, and the <warn/> <notice/> <alert/> flags... the 1.4pre1 server has had its deliver() logic changed, and this should be fixed now.. from what you said in this post, it looks like the xdb packet was infact delivered to BOTH of your xdb componenets.. (both xdb_file, and your external handler)... 

I haven't had a chance to fully look over the new deliver code, (it was written when i was on vacation, and i haven't quite caught up yet) =[, but this was supposed to be fixed in the new deliver logic.. 

What version of the server were you using for this xdb test, btw?


<snip/>
>  REPLIED:
>  <xdb type='result' from='dennis at host/jabber:x:offline' 
>      to='host' id='4'><offline xmlns='jabber:x:offline'/></xdb>
> 
>  CONNECTION TO JABBER LOST

not sure why you lost connection here... this should really only happen when you send bad xml... how are you connecting to jabberd? by base_accept?

<snip/>
> Mon Jan  8 19:13:50 2001  deliver.c:344 delivering to instance 'offlineagent'
> Mon Jan  8 19:13:50 2001  deliver.c:344 delivering to instance 'xdb'
> Mon Jan  8 19:13:50 2001  deliver.c:278 delivery failed (Server Configuration Error)

server configuration errors are used when all components return r_PASS... your component, if using base_accept will not return r_PASS (base_accept always returns r_DONE, or r_ERR)

<snip/>
> - Even though jabber claims to deliver the xdb_get to instance 'xdb' I have 
> patched the xdb_file.c file to log a notice when a jabber:x:offline request 
> is received; in this case it never sees one. (as hoped :-)

hrmm.. this is curious.. xdb should probably still be getting this packet.. (well, shouldn't, but in older versions of the server, it would)

<snip/>
> Also, when I don't put in the <ns> tags in the jabber.xml file my external 
> component receives all jabber:x:offline messages, even replies to them, but 
> the xdb_file.so module seems to 'win'. No crashes, but no point in my program 
> either :-) 

well, both components will get a copy of the packet here, each component doesn't really know the other has handled it or not... so xdb_file will handle it, and the result returned is the "best" result of all the components.. (for more info, see my jabberd API document for the deliver() function: http://docs.jabber.org/server)

> If I patch the xdb_file.so module to ignore jabber:x:offline messages, there 
> is no Server Configuration Error when sending the get request, the rest of 
> the events are the same, ie the get is received and responded to properly, 
> then a set is sent but jabber segfaults (external program never sees the set 
> though).

Not sure where this segfault is coming from... if you havent' already, see if you can get this to work under the 1.4pre1 server..

<snip/>
> Does it help if I go to 1.4 ? :-)

    hehe, not sure, but it's worth a try.. 


Keith Minkler
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 232 bytes
Desc: not available
URL: <https://www.jabber.org/jdev/attachments/20010108/edb57b39/attachment-0002.pgp>