[JDEV] Karma and Jabber 1.2 RC

[David Waite]

How about making the read buffer size configurable as well? an extra 7k per user adds up when you get into large numbers :)

-David Waite

Keith Minkler wrote:

> Jim...
>
> > If I want the corrected karma code where should I look for it and when will
> > it
> > be available?
> >
>
> It's currently available in jabber.org's CVS (HEAD "jabber2" branch) or on download.jabber.org as jabberd v1.2 final.
> > >it will only read a max of 8K not, or an effective max karma of about 81...
> > I am confused by your last statement.  Do you mean that in the fixed code,
> > the range that you can set the max karma values in the jabber.xml file is 1 to
> > 81? And, the 81 is due to the current set of constants compiled into the code?
>
> The issue goes like this... I'm using a static read buffer (was 1024 bytes) to read from the socket... It would reduce server performance to make this a dynamic sized read buffer, (to go along with the amount that the karma will allow to read), so I just kicked this up to 8K (8192 bytes), which is a full read of 81 karma, (almost a full for 82 karma)... That's all I meant by that line...
>
> The only other option would be to keep mallocing/freeing a read buffer for every read call, and that is just too expensive for the server to process, in the i/o loop.. especially if you have 100K sockets you are reading from.
>
> Keith
>
> _______________________________________________
> jdev mailing list
> jdev at jabber.org
> http://mailman.jabber.org/listinfo/jdev